Fix compilation error on linux #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check this This will only apply to windows |
|
Thanks! I used a combination of the example you provided and |
|
Do you mind if I update |
Sure 👍 |
spenserblack
changed the title
|
Travis CI is currently pointing to a cancelled build due to a force push. But this build should effectively be the same. Looks like all builds succeeded. @o2sh, do these changes look good? If so, I'll merge this. |
|
Sure go ahead, it should fix #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a compilation error when attempting to compile on Linux.
I tested this on both Windows and Linux, compiles on both. Will probably fail on MacOS, though.
Thanks for adding me as a collaborator, @o2sh!